[webkit-reviews] review granted: [Bug 215289] AudioContext / OfflineAudioContext should support a wider sample rate range : [Attachment 406211] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 215289: AudioContext / OfflineAudioContext should support a wider sample
rate range
https://bugs.webkit.org/show_bug.cgi?id=215289

Attachment 406211: Patch

https://bugs.webkit.org/attachment.cgi?id=406211&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 406211
  --> https://bugs.webkit.org/attachment.cgi?id=406211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406211&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:108
>  bool BaseAudioContext::isSampleRateRangeGood(float sampleRate)

This isn't new, but`isSampleRateRangeGood` isn't a great name. What is a "good"
sample rate, one that renders natively, or one that sounds good, or ...

`isSampleRateSupported` or `isSupportedSampleRate` would be a better name.