[webkit-reviews] review denied: [Bug 215237] Add AudioProcessingEvent Constructor : [Attachment 406123] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 215237: Add AudioProcessingEvent Constructor
https://bugs.webkit.org/show_bug.cgi?id=215237

Attachment 406123: Patch

https://bugs.webkit.org/attachment.cgi?id=406123&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 406123
  --> https://bugs.webkit.org/attachment.cgi?id=406123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406123&action=review

> Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp:56
> +    : Event(eventType, CanBubble::Yes, IsCancelable::No)

You need to be calling this other Event constructor:
Event(eventType, eventInitDict, IsTrusted::No)

AudioProcessingEventInit subclasses EventInit which allows the client to set
bubbles / cancelable to something else.

Note that this indicates you don't have enough test coverage, please add a
test.

> Source/WebCore/Modules/webaudio/AudioProcessingEvent.h:46
>      static Ref<AudioProcessingEvent> createForBindings()

I don't think we need this one.

> Source/WebCore/Modules/webaudio/AudioProcessingEvent.h:60
>      AudioProcessingEvent();

I don't think we need this constructor.

> Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl:30
>      readonly attribute unrestricted double playbackTime;

You can remove unrestricted.