[webkit-reviews] review granted: [Bug 215215] REGRESSION (r260276): instructure.com custom PDF viewer stops scrolling / loading after switching to another tab then switching back : [Attachment 406165] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 215215: REGRESSION (r260276): instructure.com custom PDF viewer stops
scrolling / loading after switching to another tab then switching back
https://bugs.webkit.org/show_bug.cgi?id=215215

Attachment 406165: patch

https://bugs.webkit.org/attachment.cgi?id=406165&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 406165
  --> https://bugs.webkit.org/attachment.cgi?id=406165
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406165&action=review

> LayoutTests/scrollingcoordinator/overflow-proxy-reattach.html:21
> +    await new Promise(requestAnimationFrame);

await UIHelper.animationFrame() ?

Note that returns on the microtask checkpoint at the end of the rAF callback;
it doesn't wait for the end of Page::updateRendering().