[webkit-reviews] review granted: [Bug 215231] [ews] Add method to send email notifications to patch author for layout test failures : [Attachment 406097] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 215231: [ews] Add method to send email notifications to patch author for
layout test failures
https://bugs.webkit.org/show_bug.cgi?id=215231

Attachment 406097: Patch

https://bugs.webkit.org/attachment.cgi?id=406097&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 406097
  --> https://bugs.webkit.org/attachment.cgi?id=406097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406097&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2108
> +    def send_email_for_new_test_failures(self, test_names):

I'm a bit more skeptical of this one, although we aren't using it yet, so I'll
r+ it.

We tend to have way more false-positives for test failures in EWS then we do
false-positives for build failures.