[webkit-reviews] review granted: [Bug 215221] WeakPtr threading assertion on editing/undo-manager/undo-manager-delete-stale-undo-items.html : [Attachment 406122] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 215221: WeakPtr threading assertion on
editing/undo-manager/undo-manager-delete-stale-undo-items.html
https://bugs.webkit.org/show_bug.cgi?id=215221

Attachment 406122: Patch

https://bugs.webkit.org/attachment.cgi?id=406122&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 406122
  --> https://bugs.webkit.org/attachment.cgi?id=406122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406122&action=review

r=me

> Source/WebCore/page/UndoItem.cpp:44
> +    if (undoManager)

NIT: perhaps use a ternary `m_document = undoManager ?
makeWeakPtr(undoManager->document()) : { };`?

> Source/WebCore/page/UndoItem.cpp:55
> +    m_undoManager = nullptr;
> +    m_document = nullptr;

I wonder if there's any significant difference/preference between ` = nullptr`
or `.clear()` ��