[webkit-reviews] review granted: [Bug 214946] [macOS] Show picker for date and datetime-local input types : [Attachment 406057] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 214946: [macOS] Show picker for date and datetime-local input types
https://bugs.webkit.org/show_bug.cgi?id=214946

Attachment 406057: Patch

https://bugs.webkit.org/attachment.cgi?id=406057&action=review




--- Comment #15 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 406057
  --> https://bugs.webkit.org/attachment.cgi?id=406057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406057&action=review

> Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm:161
> +    NSRect windowRect = [[_presentingView window]
convertRectToScreen:[_presentingView convertRect:params.anchorRectInRootView
toView:nil]];

The `params.anchorRectInRootView` here looks like a use-after-move! I think you
meant to use _params instead.