[webkit-reviews] review granted: [Bug 215100] IndexSparseSet::sort() should update m_map : [Attachment 406102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 12:52:08 PDT 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 215100: IndexSparseSet::sort() should update m_map
https://bugs.webkit.org/show_bug.cgi?id=215100

Attachment 406102: Patch

https://bugs.webkit.org/attachment.cgi?id=406102&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 406102
  --> https://bugs.webkit.org/attachment.cgi?id=406102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406102&action=review

r=me

> Source/WTF/wtf/IndexSparseSet.h:225
> +    }

It is nice if we have

#if ASSERT_ENABLED
validate();
#endif

here.


More information about the webkit-reviews mailing list