[webkit-reviews] review granted: [Bug 215219] [ews] Add method to send email notifications to patch author for build failure : [Attachment 406085] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 215219: [ews] Add method to send email notifications to patch author for
build failure
https://bugs.webkit.org/show_bug.cgi?id=215219

Attachment 406085: Patch

https://bugs.webkit.org/attachment.cgi?id=406085&action=review




--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 406085
  --> https://bugs.webkit.org/attachment.cgi?id=406085
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406085&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1446
> +    def send_email_for_new_build_failure(self):

We probably need some smarts so we don't email engineers about patches marked
obsolete, and maybe even to avoid sending emails if a patch is not marked for
review.