[webkit-reviews] review granted: [Bug 215195] DynamicsCompressorNode.reduction attribute should be a float, not an AudioParam : [Attachment 406054] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215195: DynamicsCompressorNode.reduction attribute should be a float, not
an AudioParam
https://bugs.webkit.org/show_bug.cgi?id=215195

Attachment 406054: Patch

https://bugs.webkit.org/attachment.cgi?id=406054&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 406054
  --> https://bugs.webkit.org/attachment.cgi?id=406054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406054&action=review

>>> Source/WebCore/Modules/webaudio/WebKitAudioContext.idl:79
>>> +	 [MayThrowException, ImplementedAs=createWebKitDynamicsCompressor]
WebKitDynamicsCompressorNode createDynamicsCompressor();
>> 
>> Do we need this ImplementedAs?
>> IIUC, WebKitAudioContext is already the prefixed version so this might break
existing code.
>> Also I do not see any test coverage for createWebKitDynamicsCompressor also.
> 
> There is a test here:
> LayoutTests/webaudio/dynamicscompressor-basic.html:	 compressor =
context.createDynamicsCompressor();
> 
> And it is still passing.

Oh my bad!