[webkit-reviews] review granted: [Bug 214883] Implement PerfomanceObserverInit.buffered : [Attachment 405995] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 214883: Implement PerfomanceObserverInit.buffered
https://bugs.webkit.org/show_bug.cgi?id=214883

Attachment 405995: Patch

https://bugs.webkit.org/attachment.cgi?id=405995&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 405995
  --> https://bugs.webkit.org/attachment.cgi?id=405995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405995&action=review

> Source/WebCore/page/PerformanceObserver.cpp:90
> +		   std::sort(m_entriesToDeliver.begin(),
m_entriesToDeliver.end(), PerformanceEntry::startTimeCompareLessThan);

Should this be std::stable_sort? Can two entries have the exact same start
time?