[webkit-reviews] review granted: [Bug 214973] Add support for MediaRecorder bitrate options : [Attachment 405915] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 214973: Add support for MediaRecorder bitrate options
https://bugs.webkit.org/show_bug.cgi?id=214973

Attachment 405915: Patch

https://bugs.webkit.org/attachment.cgi?id=405915&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405915
  --> https://bugs.webkit.org/attachment.cgi?id=405915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405915&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:102
> +    m_outputBitRate = bitRate;

It seems like we should log here if we don't support bitrate as well as in
outputBitRate(), since this is called directly with the value in the options
dictionary.