[webkit-reviews] review granted: [Bug 215169] Add constructor to ConvolverNode : [Attachment 406013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 11:04:43 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 215169: Add constructor to ConvolverNode
https://bugs.webkit.org/show_bug.cgi?id=215169

Attachment 406013: Patch

https://bugs.webkit.org/attachment.cgi?id=406013&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 406013
  --> https://bugs.webkit.org/attachment.cgi?id=406013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406013&action=review

> Source/WebCore/Modules/webaudio/ConvolverNode.cpp:210
> +	   return Exception { NotSupportedError, "ConvolverNode's channel count
cannot greater than 2"_s };

s/channel count cannot greater than 2/channel count cannot be greater than 2/

> Source/WebCore/Modules/webaudio/ConvolverNode.idl:3
> + * Copyright (C) 2020, Apple Inc. All rights reserved.

Is there any reason to update this copyright but not the .cpp or .h files?


More information about the webkit-reviews mailing list