[webkit-reviews] review granted: [Bug 215138] Web Inspector: Use border-inline-start/end properties instead of border-left/right for DataGrid and Table : [Attachment 405943] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 215138: Web Inspector: Use border-inline-start/end properties instead of
border-left/right for DataGrid and Table
https://bugs.webkit.org/show_bug.cgi?id=215138

Attachment 405943: Patch

https://bugs.webkit.org/attachment.cgi?id=405943&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405943
  --> https://bugs.webkit.org/attachment.cgi?id=405943
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405943&action=review

r=me, awesome!

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:-96
> -body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content {

please double check that removing `body[dir=*]` doesn't cause this to be
overridden by some other CSS declaration due to a lower specificity

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:97
> +    border-inline-end: var(--data-grid-column-border-end);

we should inline the `1px solid var(--border-color)` and eliminate
`--data-grid-column-border-end` while we're at it too ��