[webkit-reviews] review granted: [Bug 215132] Update event regions only once per frame : [Attachment 405933] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 215132: Update event regions only once per frame
https://bugs.webkit.org/show_bug.cgi?id=215132

Attachment 405933: Patch

https://bugs.webkit.org/attachment.cgi?id=405933&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 405933
  --> https://bugs.webkit.org/attachment.cgi?id=405933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405933&action=review

> Source/WebCore/dom/Document.cpp:4296
> +#if ENABLE(IOS_TOUCH_EVENTS)
> +    // updateTouchEventRegions() needs to be called only on the top
document.
> +    if (this == &topDocument())
> +	   updateTouchEventRegions();
> +#endif

Seems wrong to iterate all documents and call this, and then have each document
check if it’s the top one. Could we just move this back outside the iteration?

> Source/WebCore/dom/Document.h:1134
> +    void updateEventRegions();

Does this really need to be a member function? Seems like we could put this in
the Page and maybe in RenderView and not add a function here.