[webkit-reviews] review granted: [Bug 214884] Allow multiple calls to PerformanceObserver.observe with different types : [Attachment 405923] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 214884: Allow multiple calls to PerformanceObserver.observe with different
types
https://bugs.webkit.org/show_bug.cgi?id=214884

Attachment 405923: Patch

https://bugs.webkit.org/attachment.cgi?id=405923&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 405923
  --> https://bugs.webkit.org/attachment.cgi?id=405923
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405923&action=review

> Source/WebCore/page/PerformanceObserver.h:76
> +    bool m_typeObserver { false };

This doesn’t seem to be a great name for a boolean. It sounds like the contents
would be a "type observer", which sounds like an object, not a boolean. Maybe
m_isTypeObserver?