[webkit-reviews] review granted: [Bug 215096] Add constructor for AudioBufferSourceNode : [Attachment 405864] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 14:46:40 PDT 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215096: Add constructor for AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=215096

Attachment 405864: Patch

https://bugs.webkit.org/attachment.cgi?id=405864&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 405864
  --> https://bugs.webkit.org/attachment.cgi?id=405864
Patch

Seems that default values for some fields are listed in multiple places. I bet
some of the places aren’t actually affecting things. Would be nice to reduce
this a bit in the future. Default values that have no effect.


More information about the webkit-reviews mailing list