[webkit-reviews] review granted: [Bug 215091] Remove the ENABLE_DATA_INTERACTION feature flag : [Attachment 405855] For EWS

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 215091: Remove the ENABLE_DATA_INTERACTION feature flag
https://bugs.webkit.org/show_bug.cgi?id=215091

Attachment 405855: For EWS

https://bugs.webkit.org/attachment.cgi?id=405855&action=review




--- Comment #2 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 405855
  --> https://bugs.webkit.org/attachment.cgi?id=405855
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=405855&action=review

> Source/WebCore/page/FocusController.cpp:808
> +#if PLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT)

I'm assuming there's good reason that some of these are IOS_FAMILY and
DRAG_SUPPORT and some are just one or the other.

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:29
> +#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY)

nit: would you mind flipping this one so the order matches the others?

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:874
> +#endif // ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY)

nit: ditto