[webkit-reviews] review granted: [Bug 214966] [GTK] 2.29.4 fails to build in armhf : [Attachment 405844] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Alberto Garcia
<berto at igalia.com>'s request for review:
Bug 214966: [GTK] 2.29.4 fails to build in armhf
https://bugs.webkit.org/show_bug.cgi?id=214966

Attachment 405844: Patch

https://bugs.webkit.org/attachment.cgi?id=405844&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 405844
  --> https://bugs.webkit.org/attachment.cgi?id=405844
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405844&action=review

Thanks Berto!

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:340
> +    if ARMv7
> +	   subp cfr, CalleeRegisterSaveSize, t3
> +	   move t3, sp
> +    else
> +	   subp cfr, CalleeRegisterSaveSize, sp
> +    end

I guess there's no particularly compelling reason to keep this fallback path,
right? We could avoid the need for the condition by just always going through
the t3 register.