[webkit-reviews] review granted: [Bug 215017] Convert LinkHeader to use StringParsingBuffer : [Attachment 405692] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 215017: Convert LinkHeader to use StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=215017

Attachment 405692: Patch

https://bugs.webkit.org/attachment.cgi?id=405692&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 405692
  --> https://bugs.webkit.org/attachment.cgi?id=405692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405692&action=review

> Source/WebCore/loader/LinkHeader.cpp:54
> -    if ((chr >= '^' && chr <= 'z') || (chr >= 'A' && chr <= 'Z') || (chr >=
'0' && chr <= '9') || (chr >= '!' && chr <= '$') || chr == '&' || chr == '+' ||
chr == '-' || chr == '.')
> +    if ((character >= '^' && character <= 'z') || (character >= 'A' &&
character <= 'Z') || (character >= '0' && character <= '9') || (character >=
'!' && character <= '$') || character == '&' || character == '+' || character
== '-' || character == '.')
>	   return true;
>      return false;

I’d like to see this be made shorter by using isASCIIAlphanumeric.

Also, I’d like to use return rather than if return true else return false.