[webkit-reviews] review granted: [Bug 215004] Remove Range::create and many more uses of live ranges : [Attachment 405709] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 215004: Remove Range::create and many more uses of live ranges
https://bugs.webkit.org/show_bug.cgi?id=215004

Attachment 405709: Patch

https://bugs.webkit.org/attachment.cgi?id=405709&action=review




--- Comment #7 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 405709
  --> https://bugs.webkit.org/attachment.cgi?id=405709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405709&action=review

> Source/WebCore/dom/DocumentMarkerController.h:118
> +WEBCORE_EXPORT SimpleRange range(Node&, const DocumentMarker&);

I am not sure how I feel about this just being called "range", though I can see
the arguments against making this an overload of makeSimpleRange as well.

> Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm:479
> +    auto firstVP = [first _visiblePosition];
> +    auto secondVP = [second _visiblePosition];

Not new, but also don't think the abbreviations are great here.