[webkit-reviews] review requested: [Bug 211277] [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path : [Attachment 398156] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 30 21:06:14 PDT 2020
Lauro Moura <lmoura at igalia.com> has asked for review:
Bug 211277: [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path
https://bugs.webkit.org/show_bug.cgi?id=211277
Attachment 398156: Patch
https://bugs.webkit.org/attachment.cgi?id=398156&action=review
--- Comment #1 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 398156
--> https://bugs.webkit.org/attachment.cgi?id=398156&action=review
Patch
This version checks environment for XDG_RUNTIME_DIR instead of using the dbus
method GetMountPoint. Currently there is no direct dbus usage from webkitpy.
One issue that may still be present is the complete absence of the runtime
directory. Should flatpakutils.py create a 'fake' one or this should be in
charge of whoever uses webkit-flatpak? (e.g. the bots scripts).
More information about the webkit-reviews
mailing list