[webkit-reviews] review denied: [Bug 211249] Python3: Support Python3 in Tools/webkitpy/benchmark_runner : [Attachment 398089] patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 211249: Python3: Support Python3 in Tools/webkitpy/benchmark_runner
https://bugs.webkit.org/show_bug.cgi?id=211249

Attachment 398089: patch

https://bugs.webkit.org/attachment.cgi?id=398089&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 398089
  --> https://bugs.webkit.org/attachment.cgi?id=398089
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398089&action=review

Just a heads up: webkitpy EWS will run both Python 2 and Python 3 tests, so as
long as the Python code you are changing is tested, you can trust EWS.

> Tools/Scripts/run-benchmark:-1
> -#!/usr/bin/env python

We aren't ready to take the dive of only supporting Python 3 yet, let's keep
these she-bangs 'python'.

We still have machines without Python 3, so we're holding off transitioning
existing scripts.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:1
> +#!/usr/bin/env python3

Ditto.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:6
> +import urllib.request

Let's make sure we have Python 2 compatible imports as well...if you grep for
urllib imports in webkitpy, you'll see us using two different import calls, one
for Python 2 and one for Python 3.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:1
> +#!/usr/bin/env python3

Ditto.