[webkit-reviews] review granted: [Bug 211248] results.webkit.org: Dropped connections when uploading archives shouldn't be fatal : [Attachment 398083] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 211248: results.webkit.org: Dropped connections when uploading archives
shouldn't be fatal
https://bugs.webkit.org/show_bug.cgi?id=211248

Attachment 398083: Patch

https://bugs.webkit.org/attachment.cgi?id=398083&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 398083
  --> https://bugs.webkit.org/attachment.cgi?id=398083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review

> Tools/Scripts/webkitpy/results/upload.py:229
> +	       log_line_func(' ' * 4 + 'Failed to upload test archive to {},
results server dropped connection, likely due to archive
size.'.format(hostname))

Can we also print the archive size here?

> Tools/Scripts/webkitpy/results/upload.py:231
> +	       return True

What happens is server is down or unreachable? Do we still use this code path
or print a different error?