[webkit-reviews] review granted: [Bug 182893] [WebAuthn] Require user gestures for LocalAuthenticator : [Attachment 398016] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 182893: [WebAuthn] Require user gestures for LocalAuthenticator
https://bugs.webkit.org/show_bug.cgi?id=182893

Attachment 398016: Patch

https://bugs.webkit.org/attachment.cgi?id=398016&action=review




--- Comment #13 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 398016
  --> https://bugs.webkit.org/attachment.cgi?id=398016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398016&action=review

Looks good. r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:-1194
> -    [[configuration preferences] _setEnabled:YES
forExperimentalFeature:webAuthenticationLocalAuthenticatorExperimentalFeature()
];

I assume these preferences are no longer needed, and this is just cleanup?