[webkit-reviews] review granted: [Bug 210794] WebKit.WebContent process crashes when web developer tools are opened in Safari : [Attachment 398069] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 210794: WebKit.WebContent process crashes when web developer tools are
opened in Safari
https://bugs.webkit.org/show_bug.cgi?id=210794

Attachment 398069: Patch

https://bugs.webkit.org/attachment.cgi?id=398069&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 398069
  --> https://bugs.webkit.org/attachment.cgi?id=398069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398069&action=review

r=me with a question

>> Source/WebInspectorUI/ChangeLog:13
>> +	    was not the active execution context.
> 
> Can you add a bit more comment about why this should be done?

I had the same question. Devin said on Slack that this is needed to hide the
drop-down picker if, after a worker terminates, there are no longer any
additional contexts besides the main frame.

> Source/JavaScriptCore/inspector/InjectedScriptBase.cpp:-86
> -	   return JSON::Value::create("Exception while making a call.");

Yay, glad we no longer drop the error message on the floor.