[webkit-reviews] review granted: [Bug 211157] Remove unnecessary BinarySemaphore waits on the main thread in the network process : [Attachment 398077] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 30 12:29:34 PDT 2020


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 211157: Remove unnecessary BinarySemaphore waits on the main thread in the
network process
https://bugs.webkit.org/show_bug.cgi?id=211157

Attachment 398077: Patch

https://bugs.webkit.org/attachment.cgi?id=398077&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 398077
  --> https://bugs.webkit.org/attachment.cgi?id=398077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398077&action=review

r=me with fix

> Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:157
> +	   RunLoop::main().dispatch(WTFMove(completionHandler));

You need to WTFMove(protectedThis) too or you may cause StorageManagerSet to
get destroyed on the background queue, which would hit the assertion in the
destructor.


More information about the webkit-reviews mailing list