[webkit-reviews] review requested: [Bug 210794] WebKit.WebContent process crashes when web developer tools are opened in Safari : [Attachment 398069] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 210794: WebKit.WebContent process crashes when web developer tools are
opened in Safari
https://bugs.webkit.org/show_bug.cgi?id=210794

Attachment 398069: Patch

https://bugs.webkit.org/attachment.cgi?id=398069&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Created attachment 398069

  --> https://bugs.webkit.org/attachment.cgi?id=398069&action=review

Patch

I managed to create a valid LayoutTest for this, and with that it showed that
the attempted fix in attachment 397995 was not valid, as it's possible for the
event to already be dispatched by the time that `m_isTerminatingExecution` is
set. As such, I've added logic to the Web Inspector `InjectedScript` (and
various manager classes) to handle `TerminatedExecutionError` instead.