[webkit-reviews] review granted: [Bug 211189] [GTK4][X11] Add support for rendering web view contents : [Attachment 397970] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 211189: [GTK4][X11] Add support for rendering web view contents
https://bugs.webkit.org/show_bug.cgi?id=211189

Attachment 397970: Patch

https://bugs.webkit.org/attachment.cgi?id=397970&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 397970
  --> https://bugs.webkit.org/attachment.cgi?id=397970
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397970&action=review

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:37
> +#define WK_XVISUAL(platformDisplay)
(static_cast<Visual*>(platformDisplay.visual()))

/me sighs at X11 (╥_╥)

> Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:205
> +    auto* visual =
WK_XVISUAL(downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()));

Maybe we want to always use the WK_XVISUAL() variant and remove the #if here?
I doubt that GTK would choose one different from what
PlatformDisplayX11::visual()
finds.