[webkit-reviews] review granted: [Bug 190576] [GStreamer] fast/mediastream/get-user-media-device-id.html failing : [Attachment 397977] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 190576: [GStreamer] fast/mediastream/get-user-media-device-id.html failing
https://bugs.webkit.org/show_bug.cgi?id=190576

Attachment 397977: Patch

https://bugs.webkit.org/attachment.cgi?id=397977&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 397977
  --> https://bugs.webkit.org/attachment.cgi?id=397977
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397977&action=review

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.
cpp:102
> +	   auto sample = adoptGRef(gst_sample_new(buffer, caps.get(), nullptr,
nullptr));

Buffer seems to be leaking here as gst_sample_new takes it as [transfer none]
and it is not adopted to a GRefPtr above.