[webkit-reviews] review granted: [Bug 211213] Ensure Intl classes don't have naming conflicts with unified builds : [Attachment 398012] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 211213: Ensure Intl classes don't have naming conflicts with unified builds
https://bugs.webkit.org/show_bug.cgi?id=211213

Attachment 398012: Patch

https://bugs.webkit.org/attachment.cgi?id=398012&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 398012
  --> https://bugs.webkit.org/attachment.cgi?id=398012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398012&action=review

r=me

> Source/JavaScriptCore/runtime/IntlCollator.h:60
> +    static Vector<String> sortLocaleData(const String&, size_t);
> +    static Vector<String> searchLocaleData(const String&, size_t);
> +

Let's put it behind private: if possible.

> Source/JavaScriptCore/runtime/IntlDateTimeFormat.h:57
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

> Source/JavaScriptCore/runtime/IntlNumberFormat.h:58
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

> Source/JavaScriptCore/runtime/IntlPluralRules.h:56
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

> Source/JavaScriptCore/runtime/IntlRelativeTimeFormat.h:55
> +    static Vector<String> localeData(const String&, size_t);

Ditto.