[webkit-reviews] review granted: [Bug 211148] [iOS] Implement -markedTextRange : [Attachment 397998] Patch and tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 211148: [iOS] Implement -markedTextRange
https://bugs.webkit.org/show_bug.cgi?id=211148

Attachment 397998: Patch and tests

https://bugs.webkit.org/attachment.cgi?id=397998&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 397998
  --> https://bugs.webkit.org/attachment.cgi?id=397998
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=397998&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4493
> +    if (bool isInHorizontalWritingMode = caretRect.width() <
caretRect.height())

I find this variable name a bit misleading, since this isn’t (technically)
about writing mode, but the geometry of the caret (i.e. keeping the caret
“skinny” in either axis).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4510
> +    if (bool isInHorizontalWritingMode = caretRect.width() <
caretRect.height()) {

Ditto.