[webkit-reviews] review granted: [Bug 211195] Add better handling of an uncleared bundle identifier in WebKitTestRunner : [Attachment 397982] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 211195: Add better handling of an uncleared bundle identifier in
WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=211195

Attachment 397982: Patch

https://bugs.webkit.org/attachment.cgi?id=397982&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 397982
  --> https://bugs.webkit.org/attachment.cgi?id=397982
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397982&action=review

Thank you!

> Tools/WebKitTestRunner/TestController.cpp:644
> +	   // ASSERT the bundle identifier has not already been set, since it
can only be set once.

I think that it would be better wording to not restate what the code does. So
I'd say "The bundle identifier can only be set once."

Maybe also add an explanation of how to resolve this, for the person hitting
this. Something like this, if it's accurate: "WebContent process needs to be
relaunched after every test that sets the bundle identifier."