[webkit-reviews] review granted: [Bug 211197] REGRESSION (r246395): Leak of ARQuickLookPreviewItem and ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource previewController:previewItemAtIndex:] : [Attachment 397988] Patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 211197: REGRESSION (r246395): Leak of ARQuickLookPreviewItem and
ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource
previewController:previewItemAtIndex:]
https://bugs.webkit.org/show_bug.cgi?id=211197

Attachment 397988: Patch v2

https://bugs.webkit.org/attachment.cgi?id=397988&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 397988
  --> https://bugs.webkit.org/attachment.cgi?id=397988
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=397988&action=review

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:113
> +    previewItem.get().canonicalWebPageURL = _originatingPageURL;

Some WebKit contributors prefer this style to sidestep the get():

    [previewItem setCanonicalWebPageURL:_originatingPageURL];