[webkit-reviews] review granted: [Bug 210994] REGRESSION (r256784?): Shadertoy demo no longer works in Safari : [Attachment 397926] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 210994: REGRESSION (r256784?): Shadertoy demo no longer works in Safari
https://bugs.webkit.org/show_bug.cgi?id=210994

Attachment 397926: Patch

https://bugs.webkit.org/attachment.cgi?id=397926&action=review




--- Comment #21 from Dean Jackson <dino at apple.com> ---
Comment on attachment 397926
  --> https://bugs.webkit.org/attachment.cgi?id=397926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397926&action=review

> Source/WebCore/html/canvas/OESTextureFloat.cpp:40
> +   
context.graphicsContextGL()->getExtensions().ensureEnabled("GL_CHROMIUM_color_b
uffer_float_rgb"_s);
> +   
context.graphicsContextGL()->getExtensions().ensureEnabled("GL_CHROMIUM_color_b
uffer_float_rgba"_s);

I wonder if we should USE(ANGLE) here, although it doesn't hurt that it is
missing.