[webkit-reviews] review granted: [Bug 211138] Make PolicyChecker an inner class of FrameLoader : [Attachment 397883] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 211138: Make PolicyChecker an inner class of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=211138

Attachment 397883: Patch

https://bugs.webkit.org/attachment.cgi?id=397883&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 397883
  --> https://bugs.webkit.org/attachment.cgi?id=397883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397883&action=review

> Source/WebCore/loader/FrameLoader.h:112
>      PolicyChecker& policyChecker() const { return *m_policyChecker; }

You could make m_policyChecker a UniqueRef

> Source/WebCore/loader/FrameLoaderTypes.h:115
> +enum class ShouldContinuePolicyCheck : uint8_t {

bool

> Source/WebCore/loader/PolicyChecker.h:114
> +template<> struct EnumTraits<WebCore::ShouldContinuePolicyCheck> {

This is not needed if ShouldContinuePolicyCheck has a bool underlying type.