[webkit-reviews] review granted: [Bug 211142] U_STRING_NOT_TERMINATED_WARNING ICU must be handled when using the output buffer as a C string : [Attachment 397904] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 20:04:56 PDT 2020


Mark Lam <mark.lam at apple.com> has granted  review:
Bug 211142: U_STRING_NOT_TERMINATED_WARNING ICU must be handled when using the
output buffer as a C string
https://bugs.webkit.org/show_bug.cgi?id=211142

Attachment 397904: patch

https://bugs.webkit.org/attachment.cgi?id=397904&action=review




--- Comment #18 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 397904
  --> https://bugs.webkit.org/attachment.cgi?id=397904
patch

Restoring Darin's r+ since Saam said he will undo the
StringImpl::createStaticStringImpl() change.


More information about the webkit-reviews mailing list