[webkit-reviews] review granted: [Bug 211139] [WebKitLegacy] Implement -hidePlaceholder and -showPlaceholderIfNecessary in terms of setCanShowPlaceholder() : [Attachment 397871] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 16:25:48 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 211139: [WebKitLegacy] Implement -hidePlaceholder and
-showPlaceholderIfNecessary in terms of setCanShowPlaceholder()
https://bugs.webkit.org/show_bug.cgi?id=211139

Attachment 397871: Patch

https://bugs.webkit.org/attachment.cgi?id=397871&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 397871
  --> https://bugs.webkit.org/attachment.cgi?id=397871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397871&action=review

> Source/WebKitLegacy/mac/ChangeLog:11
> +		   1. Unlike -hidePlaceholder and -showPlaceholderIfNecessary,
setCanShowPlaceholder() does NOT of

So much indent.


More information about the webkit-reviews mailing list