[webkit-reviews] review granted: [Bug 211144] [GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern on a bytes-like object : [Attachment 397893] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 211144: [GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern
on a bytes-like object
https://bugs.webkit.org/show_bug.cgi?id=211144

Attachment 397893: Patch

https://bugs.webkit.org/attachment.cgi?id=397893&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 397893
  --> https://bugs.webkit.org/attachment.cgi?id=397893
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397893&action=review

LGTM, thanks.

> Tools/ChangeLog:12
> +	   Also check if the doc directory exists before passing it to bwrap.
> +	   Should avoid errors like these:
> +
> +	   bwrap: Can't find source path /run/user/1000/doc: No such file or
directory

Hm, well I actually do have /run/user/1000/doc. That error must have been
caused because the script was not mounting /run/user/1000/doc, it was mounting
/run/user/b'1000'/doc. Oops. :) I'll let you decide whether it's still worth
checking if that exists.