[webkit-reviews] review granted: [Bug 211147] AsyncFromSyncIterator methods should not pass absent values : [Attachment 397888] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 211147: AsyncFromSyncIterator methods should not pass absent values
https://bugs.webkit.org/show_bug.cgi?id=211147

Attachment 397888: Patch

https://bugs.webkit.org/attachment.cgi?id=397888&action=review




--- Comment #5 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 397888
  --> https://bugs.webkit.org/attachment.cgi?id=397888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397888&action=review

> Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:42
> +	   var nextResult = @argumentCount() === 0 ?
nextMethod. at call(syncIterator) : nextMethod. at call(syncIterator, value);

Seems good as long as we're meant to distinguish explicit `undefined`.