[webkit-reviews] review granted: [Bug 211140] [JSC] Align upon the name isCallable instead of isFunction : [Attachment 397870] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 211140: [JSC] Align upon the name isCallable instead of isFunction
https://bugs.webkit.org/show_bug.cgi?id=211140

Attachment 397870: Patch

https://bugs.webkit.org/attachment.cgi?id=397870&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 397870
  --> https://bugs.webkit.org/attachment.cgi?id=397870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397870&action=review

r=me assuming the EWS confirms this compiles everywhere

> Source/JavaScriptCore/runtime/JSCJSValueInlines.h:894
>      if (!isCell())
>	   return false;
> -    return asCell()->isFunction(vm);
> +    return asCell()->isCallable(vm);

I really like && for functions like this:

    return isCell() && asCell()->isCallable(vm);

Obviously that has nothing to do with this patch.