[webkit-reviews] review granted: [Bug 113588] Web Inspector: find dialog does not populate search string from system find pasteboard : [Attachment 397804] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 113588: Web Inspector: find dialog does not populate search string from
system find pasteboard
https://bugs.webkit.org/show_bug.cgi?id=113588

Attachment 397804: Patch

https://bugs.webkit.org/attachment.cgi?id=397804&action=review




--- Comment #9 from Brian Burg <bburg at apple.com> ---
Comment on attachment 397804
  --> https://bugs.webkit.org/attachment.cgi?id=397804
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397804&action=review

r=me!

> Source/WebKit/UIProcess/Inspector/mac/WKInspectorWKWebView.mm:98
> +    [self.inspectorWKWebViewDelegate
inspectorWKWebViewDidBecomeActive:self];

Nit: usually prefer to use the ivar in this situation,
_inspectorWKWebViewDelegate.

> Source/WebKit/UIProcess/Inspector/mac/WKInspectorWKWebView.mm:104
> +    if ([notification object] == [self window])

nit: notification.object, self.window