[webkit-reviews] review granted: [Bug 211109] Web Inspector: Debug: "Outline focused element" should also outline elements with tabIndex=0 : [Attachment 397776] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 211109: Web Inspector: Debug: "Outline focused element" should also outline
elements with tabIndex=0
https://bugs.webkit.org/show_bug.cgi?id=211109

Attachment 397776: Patch

https://bugs.webkit.org/attachment.cgi?id=397776&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 397776
  --> https://bugs.webkit.org/attachment.cgi?id=397776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397776&action=review

r=me

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26
> +body.focus-debug [tabindex="0"] {

Would it be worth having additional colors for `[tabindex="-1"]` and
`[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well?