[webkit-reviews] review denied: [Bug 211108] Web Inspector: Use standardized `:is` CSS selector instead of `:matches` : [Attachment 397772] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 12:09:17 PDT 2020


Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 211108: Web Inspector: Use standardized `:is` CSS selector instead of
`:matches`
https://bugs.webkit.org/show_bug.cgi?id=211108

Attachment 397772: Patch

https://bugs.webkit.org/attachment.cgi?id=397772&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 397772
  --> https://bugs.webkit.org/attachment.cgi?id=397772
Patch

r-, as since `:matches` is allowed as an obsolete alias for `:is` there's no
need to remove it.  We should just prefer using `:is` going forward, and change
previous uses as we come across them (same as how we treat usage of `var`).


More information about the webkit-reviews mailing list