[webkit-reviews] review granted: [Bug 211102] [MacCatalyst] Add missing symlinks to WebKit.frameworks : [Attachment 397777] Patch v1

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 211102: [MacCatalyst] Add missing symlinks to WebKit.frameworks
https://bugs.webkit.org/show_bug.cgi?id=211102

Attachment 397777: Patch v1

https://bugs.webkit.org/attachment.cgi?id=397777&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 397777
  --> https://bugs.webkit.org/attachment.cgi?id=397777
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=397777&action=review

>>> Source/WebKit/WebKit.xcodeproj/project.pbxproj:12143
>>> +			shellScript = "if [[ \"${WK_PLATFORM_NAME}\" == macosx
|| \"${WK_PLATFORM_NAME}\" == maccatalyst || \"${WK_PLATFORM_NAME}\" == iosmac
]]; then\n    ln -sfh \"Versions/Current/Frameworks\"
\"${TARGET_BUILD_DIR}/WebKit.framework/Frameworks\"\nfi\n";
>> 
>> Why both iosmac and maccatalyst?
> 
> For consistency with the same check in
Source/Webkit/Scripts/process-entitlements.sh.

We should get rid of the iosmac stuff in a future patch.