[webkit-reviews] review granted: [Bug 207600] Nullptr crash in EditCommand::EditCommand via CompositeEditCommand::removeNode : [Attachment 397809] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 28 09:19:50 PDT 2020
Geoffrey Garen <ggaren at apple.com> has granted Jack <shihchieh_lee at apple.com>'s
request for review:
Bug 207600: Nullptr crash in EditCommand::EditCommand via
CompositeEditCommand::removeNode
https://bugs.webkit.org/show_bug.cgi?id=207600
Attachment 397809: Patch
https://bugs.webkit.org/attachment.cgi?id=397809&action=review
--- Comment #54 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 397809
--> https://bugs.webkit.org/attachment.cgi?id=397809
Patch
I'll say r+ because this patch passed EWS and it seems ready to go. Please
follow up to remove that m_frame data member, since that will be the
compile-time verification that instances of this bug are gone.
More information about the webkit-reviews
mailing list