[webkit-reviews] review requested: [Bug 207372] [WPE][WebDriver] Implement user prompt support : [Attachment 397826] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 04:10:13 PDT 2020


Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 207372: [WPE][WebDriver] Implement user prompt support
https://bugs.webkit.org/show_bug.cgi?id=207372

Attachment 397826: Updated patch

https://bugs.webkit.org/attachment.cgi?id=397826&action=review




--- Comment #20 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 397826

  --> https://bugs.webkit.org/attachment.cgi?id=397826&action=review

Updated patch

Updated the patch by adding a function to check whether the dialog was user
handled and only falling back to the default behavior if we're using this
default impl. Also fixed the WPE accept handler to use the default text the
user provided not text.


More information about the webkit-reviews mailing list