[webkit-reviews] review granted: [Bug 211096] compilePeepHoleBigInt32Branch needs to handle all conditions : [Attachment 397756] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 211096: compilePeepHoleBigInt32Branch needs to handle all conditions
https://bugs.webkit.org/show_bug.cgi?id=211096

Attachment 397756: patch

https://bugs.webkit.org/attachment.cgi?id=397756&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 397756
  --> https://bugs.webkit.org/attachment.cgi?id=397756
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397756&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:1782
>  

I recommend putting

GPRReg op1GPR = op1.gpr();
GPRReg op2GPR = op2.gpr();

And use op1GPR and op2GPR.