[webkit-reviews] review granted: [Bug 211090] Make HistoryController an inner class of FrameLoader : [Attachment 397725] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 27 14:30:38 PDT 2020


Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 211090: Make HistoryController an inner class of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=211090

Attachment 397725: Patch

https://bugs.webkit.org/attachment.cgi?id=397725&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 397725
  --> https://bugs.webkit.org/attachment.cgi?id=397725
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397725&action=review

> Source/WebCore/loader/HistoryController.h:32
> -#include "FrameLoaderTypes.h"
> +#include "FrameLoader.h"

I’d think you could remove many of the includes below after making this change.


More information about the webkit-reviews mailing list