[webkit-reviews] review granted: [Bug 211080] Stop using waiting for a BinarySemaphore on the main thread in the NetworkProcess : [Attachment 397729] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 211080: Stop using waiting for a BinarySemaphore on the main thread in the
NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=211080

Attachment 397729: Patch

https://bugs.webkit.org/attachment.cgi?id=397729&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 397729
  --> https://bugs.webkit.org/attachment.cgi?id=397729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397729&action=review

r=me but let's wait for EWS to be green to land.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:270
> +	   networkSession.destroyResourceLoadStatistics([callbackAggregator =
callbackAggregator.copyRef()] { });

Yes, this is probably a good idea to do.