[webkit-reviews] review granted: [Bug 211089] [JSC] Add $vm.assertEnabled() to suppress Debug crash expected tests in release+assert build : [Attachment 397715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 27 12:33:43 PDT 2020


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 211089: [JSC] Add $vm.assertEnabled() to suppress Debug crash expected
tests in release+assert build
https://bugs.webkit.org/show_bug.cgi?id=211089

Attachment 397715: Patch

https://bugs.webkit.org/attachment.cgi?id=397715&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 397715
  --> https://bugs.webkit.org/attachment.cgi?id=397715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397715&action=review

r=me with suggestion

>
JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-fla
tten.js:19
> +if (!$vm.assertEnabled()) {

Why not `if (!$vm.assertEnabled()) quit()`


More information about the webkit-reviews mailing list